Chromium Code Reviews
Help | Chromium Project | Sign in
(701)

Issue 6303004: Cleanup: replace usage of "pk11" with "pkcs11" or "crypto module", as appropriate. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by mattm
Modified:
2 years, 11 months ago
Reviewers:
tfarina, wtc
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Cleanup for r71281: replace usage of "pk11" with "pkcs11" or "crypto module", as appropriate.

BUG=42073
TEST=manual,trybotss

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71749

Patch Set 1 #

Total comments: 5

Patch Set 2 : indentation, compile fix #

Total comments: 9

Patch Set 3 : rebase, addressing comments #

Patch Set 4 : sorting fix again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -146 lines) Lint Patch
M base/base.gypi View 1 2 2 chunks +1 line, -1 line 0 comments ? errors Download
A + base/crypto/crypto_module_blocking_password_delegate.h View 1 2 3 chunks +9 lines, -9 lines 0 comments ? errors Download
M base/nss_util.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments ? errors Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +9 lines, -9 lines 0 comments ? errors Download
M chrome/browser/dom_ui/options/certificate_manager_handler.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/render_message_filter.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments ? errors Download
A + chrome/browser/ui/crypto_module_password_dialog.h View 1 2 4 chunks +22 lines, -21 lines 0 comments ? errors Download
A + chrome/browser/ui/crypto_module_password_dialog_nss.cc View 1 2 6 chunks +8 lines, -8 lines 0 comments 0 errors Download
A + chrome/browser/ui/crypto_module_password_dialog_openssl.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments 0 errors Download
A + chrome/browser/ui/gtk/crypto_module_password_dialog.cc View 1 2 11 chunks +67 lines, -59 lines 0 comments 0 errors Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 1 2 3 9 chunks +9 lines, -9 lines 0 comments ? errors Download
M net/base/keygen_handler.h View 3 chunks +5 lines, -3 lines 0 comments ? errors Download
M net/base/keygen_handler.cc View 1 chunk +3 lines, -3 lines 0 comments 0 errors Download
M net/base/keygen_handler_nss.cc View 3 chunks +5 lines, -5 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 4
mattm
3 years, 3 months ago #1
tfarina
I don't think it's worth updating the copyright year, but it's good though (there aren't ...
3 years, 3 months ago #2
wtc
LGTM! http://codereview.chromium.org/6303004/diff/5001/base/crypto/crypto_module_blocking_password_delegate.h File base/crypto/crypto_module_blocking_password_delegate.h (right): http://codereview.chromium.org/6303004/diff/5001/base/crypto/crypto_module_blocking_password_delegate.h#newcode17 base/crypto/crypto_module_blocking_password_delegate.h:17: class CryptoModuleBlockingPasswordDelegate { If this class is and ...
3 years, 3 months ago #3
mattm
3 years, 3 months ago #4
http://codereview.chromium.org/6303004/diff/1/chrome/browser/gtk/crypto_modul...
File chrome/browser/gtk/crypto_module_password_dialog.cc (right):

http://codereview.chromium.org/6303004/diff/1/chrome/browser/gtk/crypto_modul...
chrome/browser/gtk/crypto_module_password_dialog.cc:27: const std::string&
server)
On 2011/01/13 23:52:27, tfarina wrote:
> wrong indentation. 

Done.

http://codereview.chromium.org/6303004/diff/1/chrome/browser/gtk/crypto_modul...
chrome/browser/gtk/crypto_module_password_dialog.cc:84: bool retry,
On 2011/01/13 23:52:27, tfarina wrote:
> wrong indentation. 

Done.

http://codereview.chromium.org/6303004/diff/5001/base/crypto/crypto_module_bl...
File base/crypto/crypto_module_blocking_password_delegate.h (right):

http://codereview.chromium.org/6303004/diff/5001/base/crypto/crypto_module_bl...
base/crypto/crypto_module_blocking_password_delegate.h:17: class
CryptoModuleBlockingPasswordDelegate {
On 2011/01/15 17:40:40, wtc wrote:
> If this class is and will remain NSS-specific, it is fine
> to use "PKCS11" instead of "CryptoModule" in its name.
> I guess this class will also be used by the use_openssl
> build?

Yeah, openssl will use it too

http://codereview.chromium.org/6303004/diff/5001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/6303004/diff/5001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6520: <!-- NSS PKCS11 password dialog -->
On 2011/01/15 17:40:40, wtc wrote:
> Nit: in comments, it's better to use "PKCS #11".  I won't
> insist on this.

Done.

http://codereview.chromium.org/6303004/diff/5001/chrome/browser/dom_ui/option...
File chrome/browser/dom_ui/options/certificate_manager_handler.cc (right):

http://codereview.chromium.org/6303004/diff/5001/chrome/browser/dom_ui/option...
chrome/browser/dom_ui/options/certificate_manager_handler.cc:22: #include
"chrome/common/net/x509_certificate_model.h"
On 2011/01/15 17:40:40, wtc wrote:
> Just curious: why do we need to include x509_certificate_model.h?

It snuck in from a different change.  Removed.

http://codereview.chromium.org/6303004/diff/5001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/6303004/diff/5001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:1529: 'browser/gtk/crypto_module_password_dialog.cc',
On 2011/01/15 17:40:40, wtc wrote:
> Nit: list this file in alphabetical order now that it's
> renamed.  This comment also applies to some other changes
> in this file.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6