Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 630223003: Add GetExplicitPassphraseTime() JNI call. (Closed)

Created:
6 years, 2 months ago by maxbogue
Modified:
6 years, 2 months ago
Reviewers:
nyquist, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add GetExplicitPassphraseTime() JNI call. This change is in preparation for a bug fix in Chrome for Android. BUG=419927 Committed: https://crrev.com/c021ddccd905f12d0c0ce24615fc39303e6f5176 Cr-Commit-Position: refs/heads/master@{#298896}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
maxbogue
6 years, 2 months ago (2014-10-07 17:30:35 UTC) #2
Nicolas Zea
lgtm
6 years, 2 months ago (2014-10-08 17:35:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630223003/1
6 years, 2 months ago (2014-10-08 17:37:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16344)
6 years, 2 months ago (2014-10-08 17:46:11 UTC) #7
maxbogue
Need OWNERS for the java file.
6 years, 2 months ago (2014-10-08 17:59:04 UTC) #9
nyquist
lgtm after you add a comment https://codereview.chromium.org/630223003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java File chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java (right): https://codereview.chromium.org/630223003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java#newcode239 chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:239: public long getExplicitPassphraseTime() ...
6 years, 2 months ago (2014-10-08 18:28:33 UTC) #10
maxbogue
Thanks for the quick reviews! https://codereview.chromium.org/630223003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java File chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java (right): https://codereview.chromium.org/630223003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java#newcode239 chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java:239: public long getExplicitPassphraseTime() { ...
6 years, 2 months ago (2014-10-08 18:39:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630223003/20001
6 years, 2 months ago (2014-10-08 18:40:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/66262)
6 years, 2 months ago (2014-10-08 19:27:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630223003/20001
6 years, 2 months ago (2014-10-08 19:48:23 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/66262)
6 years, 2 months ago (2014-10-08 20:42:28 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630223003/20001
6 years, 2 months ago (2014-10-09 15:58:51 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c9c76f0f8467406db6bccf6430f5f710744e6166
6 years, 2 months ago (2014-10-09 16:21:31 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 16:23:36 UTC) #23
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c021ddccd905f12d0c0ce24615fc39303e6f5176
Cr-Commit-Position: refs/heads/master@{#298896}

Powered by Google App Engine
This is Rietveld 408576698