Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: tools/gn/function_read_file.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/function_read_file.cc
diff --git a/tools/gn/function_read_file.cc b/tools/gn/function_read_file.cc
index f35e5a67fe18c25aaaec2b6d10e9b86ae65e8835..5a7662a672032596dc72b63baa9ea4bf67e9d37f 100644
--- a/tools/gn/function_read_file.cc
+++ b/tools/gn/function_read_file.cc
@@ -53,7 +53,8 @@ Value RunReadFile(Scope* scope,
// Compute the file name.
const SourceDir& cur_dir = scope->GetSourceDir();
- SourceFile source_file = cur_dir.ResolveRelativeFile(args[0].string_value());
+ SourceFile source_file = cur_dir.ResolveRelativeFile(args[0].string_value(),
+ scope->settings()->build_settings()->root_path_utf8());
base::FilePath file_path =
scope->settings()->build_settings()->GetFullPath(source_file);

Powered by Google App Engine
This is Rietveld 408576698