Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/gn/label_pattern.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/label_pattern.cc
diff --git a/tools/gn/label_pattern.cc b/tools/gn/label_pattern.cc
index 752898f1acace2f03bdddc25315da680728b6d00..ff6b34af0751b57fe84e051448e189a0ad06ed04 100644
--- a/tools/gn/label_pattern.cc
+++ b/tools/gn/label_pattern.cc
@@ -166,7 +166,7 @@ LabelPattern LabelPattern::GetPattern(const SourceDir& current_dir,
}
// Resolve the non-wildcard stuff.
- dir = current_dir.ResolveRelativeDir(path);
+ dir = current_dir.ResolveRelativeDir(path, base::FilePath());
if (dir.is_null()) {
*err = Err(value, "Label pattern didn't resolve to a dir.",
"The directory name \"" + path.as_string() + "\" didn't\n"

Powered by Google App Engine
This is Rietveld 408576698