Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/function_write_file.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/filesystem_utils.cc ('K') | « tools/gn/function_rebase_path.cc ('k') | tools/gn/functions.cc » ('j') | tools/gn/source_dir.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_write_file.cc
diff --git a/tools/gn/function_write_file.cc b/tools/gn/function_write_file.cc
index 55f4d5dc63a0e543fe9d58dfca7cbb2968188356..a02a54677208ab3f222bf60a035855e692722e86 100644
--- a/tools/gn/function_write_file.cc
+++ b/tools/gn/function_write_file.cc
@@ -57,7 +57,8 @@ Value RunWriteFile(Scope* scope,
if (!args[0].VerifyTypeIs(Value::STRING, err))
return Value();
const SourceDir& cur_dir = scope->GetSourceDir();
- SourceFile source_file = cur_dir.ResolveRelativeFile(args[0].string_value());
+ SourceFile source_file = cur_dir.ResolveRelativeFile(args[0].string_value(),
+ scope->settings()->build_settings()->root_path());
if (!EnsureStringIsInOutputDir(
scope->settings()->build_settings()->build_dir(),
source_file.value(), args[0].origin(), err))
« tools/gn/filesystem_utils.cc ('K') | « tools/gn/function_rebase_path.cc ('k') | tools/gn/functions.cc » ('j') | tools/gn/source_dir.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698