Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/command_format.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/build_settings.cc ('k') | tools/gn/filesystem_utils.h » ('j') | tools/gn/filesystem_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_format.cc
diff --git a/tools/gn/command_format.cc b/tools/gn/command_format.cc
index b1a7ee3cdb36a410073e8c2e06fe9500c136a809..ff1d9b0f19550d25c53a4dbd5822d8088fec8244 100644
--- a/tools/gn/command_format.cc
+++ b/tools/gn/command_format.cc
@@ -707,7 +707,8 @@ int RunFormat(const std::vector<std::string>& args) {
Setup setup;
SourceDir source_dir =
SourceDirForCurrentDirectory(setup.build_settings().root_path());
- SourceFile file = source_dir.ResolveRelativeFile(args[0]);
+ SourceFile file = source_dir.ResolveRelativeFile(args[0],
+ setup.build_settings().root_path());
std::string output_string;
if (FormatFileToString(&setup, file, dump_tree, &output_string)) {
« no previous file with comments | « tools/gn/build_settings.cc ('k') | tools/gn/filesystem_utils.h » ('j') | tools/gn/filesystem_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698