tools/gn/setup.cc - Issue 630223002: gn: Support build directories outside the source tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/setup.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch that compiles and passes unit tests on both Windows and Linux Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/setup.cc

diff --git a/tools/gn/setup.cc b/tools/gn/setup.cc

index fdbf0f24798f4d417e203d8e0b4d094df05c3134..5ba87b934bbe9da8d978b75da325623c9fd7f1be 100644

--- a/tools/gn/setup.cc

+++ b/tools/gn/setup.cc

@@ -441,7 +441,7 @@ bool Setup::FillSourceDir(const CommandLine& cmdline) {

bool Setup::FillBuildDir(const std::string& build_dir, bool require_exists) {

SourceDir resolved =

SourceDirForCurrentDirectory(build_settings_.root_path()).

- ResolveRelativeDir(build_dir);

+ ResolveRelativeDir(build_dir, build_settings_.root_path_utf8());

if (resolved.is_null()) {

Err(Location(), "Couldn't resolve build directory.",

"The build directory supplied (\"" + build_dir + "\") was not valid.").

« no previous file with comments | « tools/gn/path_output_unittest.cc ('k') | tools/gn/source_dir.cc » ('j') | no next file with comments »