tools/gn/ninja_toolchain_writer.cc - Issue 630223002: gn: Support build directories outside the source tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch that compiles and passes unit tests on both Windows and Linux Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/ninja_toolchain_writer.cc

diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc

index 5deead51dbfc722e15c6b5f92639c415c5d01ab7..012247103001075e7b321a2402f05977fea03c5e 100644

--- a/tools/gn/ninja_toolchain_writer.cc

+++ b/tools/gn/ninja_toolchain_writer.cc

@@ -32,7 +32,9 @@ NinjaToolchainWriter::NinjaToolchainWriter(

toolchain_(toolchain),

targets_(targets),

out_(out),

- path_output_(settings_->build_settings()->build_dir(), ESCAPE_NINJA) {

+ path_output_(settings_->build_settings()->build_dir(),

+ settings_->build_settings()->root_path_utf8(),

+ ESCAPE_NINJA) {

}

NinjaToolchainWriter::~NinjaToolchainWriter() {

« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/output_file.cc » ('j') | no next file with comments »