tools/gn/function_write_file.cc - Issue 630223002: gn: Support build directories outside the source tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/function_write_file.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch that compiles and passes unit tests on both Windows and Linux Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/function_write_file.cc

diff --git a/tools/gn/function_write_file.cc b/tools/gn/function_write_file.cc

index 55f4d5dc63a0e543fe9d58dfca7cbb2968188356..0d273fc5973fed3a9ce8ca7fd477500c22952af7 100644

--- a/tools/gn/function_write_file.cc

+++ b/tools/gn/function_write_file.cc

@@ -57,7 +57,8 @@ Value RunWriteFile(Scope* scope,

if (!args[0].VerifyTypeIs(Value::STRING, err))

return Value();

const SourceDir& cur_dir = scope->GetSourceDir();

- SourceFile source_file = cur_dir.ResolveRelativeFile(args[0].string_value());

+ SourceFile source_file = cur_dir.ResolveRelativeFile(args[0].string_value(),

+ scope->settings()->build_settings()->root_path_utf8());

if (!EnsureStringIsInOutputDir(

scope->settings()->build_settings()->build_dir(),

source_file.value(), args[0].origin(), err))

« no previous file with comments | « tools/gn/function_rebase_path_unittest.cc ('k') | tools/gn/functions.cc » ('j') | no next file with comments »