Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1992)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/output_file.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/filesystem_utils.cc ('K') | « tools/gn/ninja_toolchain_writer.cc ('k') | tools/gn/path_output.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/output_file.cc
diff --git a/tools/gn/output_file.cc b/tools/gn/output_file.cc
index d1fb88e8ee692951c9927856d8574c131743da1e..d90cb6c3ae669e735eca79af7efaae3397939c70 100644
--- a/tools/gn/output_file.cc
+++ b/tools/gn/output_file.cc
@@ -17,7 +17,8 @@ OutputFile::OutputFile(const base::StringPiece& str)
OutputFile::OutputFile(const BuildSettings* build_settings,
const SourceFile& source_file)
: value_(RebaseSourceAbsolutePath(source_file.value(),
- build_settings->build_dir())) {
+ build_settings->build_dir(),
+ build_settings->root_path())) {
}
OutputFile::~OutputFile() {
« tools/gn/filesystem_utils.cc ('K') | « tools/gn/ninja_toolchain_writer.cc ('k') | tools/gn/path_output.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698