Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/function_toolchain.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/filesystem_utils.cc ('K') | « tools/gn/function_set_default_toolchain.cc ('k') | tools/gn/function_write_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index 85163c173a5c0607ce44f2bb323e4e0b86402b85..2db6474aebdb4bf600af6639461e8dcd9ec2bb76 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -311,6 +311,7 @@ Value RunToolchain(Scope* scope,
const Value* deps_value = block_scope.GetValue(variables::kDeps, true);
if (deps_value) {
ExtractListOfLabels(
+ scope->settings()->build_settings(),
*deps_value, block_scope.GetSourceDir(),
ToolchainLabelForScope(&block_scope), &toolchain->deps(), err);
if (err->has_error())
« tools/gn/filesystem_utils.cc ('K') | « tools/gn/function_set_default_toolchain.cc ('k') | tools/gn/function_write_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698