Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: tools/gn/item.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch set Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h"
5 #include "tools/gn/item.h" 6 #include "tools/gn/item.h"
brettw 2014/11/05 19:59:49 This should be first with a blank line after it si
zeuthen 2014/11/07 19:24:12 Done.
6 7 #include "tools/gn/settings.h"
7 #include "base/logging.h"
8 8
9 Item::Item(const Settings* settings, const Label& label) 9 Item::Item(const Settings* settings, const Label& label)
10 : settings_(settings), 10 : settings_(settings),
11 label_(label), 11 label_(label),
12 defined_from_(NULL) { 12 defined_from_(NULL) {
13 } 13 }
14 14
15 Item::~Item() { 15 Item::~Item() {
16 } 16 }
17 17
(...skipping 11 matching lines...) Expand all
29 return "target"; 29 return "target";
30 if (AsToolchain()) 30 if (AsToolchain())
31 return "toolchain"; 31 return "toolchain";
32 NOTREACHED(); 32 NOTREACHED();
33 return "this thing that I have no idea what it is"; 33 return "this thing that I have no idea what it is";
34 } 34 }
35 35
36 bool Item::OnResolved(Err* err) { 36 bool Item::OnResolved(Err* err) {
37 return true; 37 return true;
38 } 38 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698