Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: tools/gn/item.cc

Issue 630223002: gn: Support build directories outside the source tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch that compiles and passes unit tests on both Windows and Linux Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/ninja_action_target_writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/item.h" 5 #include "tools/gn/item.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "tools/gn/settings.h"
8 9
9 Item::Item(const Settings* settings, const Label& label) 10 Item::Item(const Settings* settings, const Label& label)
10 : settings_(settings), 11 : settings_(settings),
11 label_(label), 12 label_(label),
12 defined_from_(NULL) { 13 defined_from_(NULL) {
13 } 14 }
14 15
15 Item::~Item() { 16 Item::~Item() {
16 } 17 }
17 18
(...skipping 11 matching lines...) Expand all
29 return "target"; 30 return "target";
30 if (AsToolchain()) 31 if (AsToolchain())
31 return "toolchain"; 32 return "toolchain";
32 NOTREACHED(); 33 NOTREACHED();
33 return "this thing that I have no idea what it is"; 34 return "this thing that I have no idea what it is";
34 } 35 }
35 36
36 bool Item::OnResolved(Err* err) { 37 bool Item::OnResolved(Err* err) {
37 return true; 38 return true;
38 } 39 }
OLDNEW
« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/ninja_action_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698