Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 630143002: Revert of Re-enabling fixed WebRTC getusermedia tests. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enabling fixed WebRTC getusermedia tests. (patchset #1 id:1 of https://codereview.chromium.org/623733002/) Reason for revert: still flaky, see bug Original issue's description: > Re-enabling fixed WebRTC getusermedia tests. > > BUG=417756 > > Committed: https://crrev.com/9fa6d13fdbac6c82917c23c9b63b4f3cb7b7593e > Cr-Commit-Position: refs/heads/master@{#298205} TBR=perkj@chromium.org,kjellander@chromium.org,phoglund@chromium.org NOTREECHECKS=true NOTRY=true BUG=417756 Committed: https://crrev.com/290d2cfa5187ac1f2c87fde4c6dd6f27dad0c93a Cr-Commit-Position: refs/heads/master@{#298262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M content/browser/media/webrtc_getusermedia_browsertest.cc View 4 chunks +39 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Re-enabling fixed WebRTC getusermedia tests.
6 years, 2 months ago (2014-10-06 17:21:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630143002/1
6 years, 2 months ago (2014-10-06 17:22:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as dca1a27f3d07eea480bcc22b20b0c85b42852502
6 years, 2 months ago (2014-10-06 17:24:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/290d2cfa5187ac1f2c87fde4c6dd6f27dad0c93a Cr-Commit-Position: refs/heads/master@{#298262}
6 years, 2 months ago (2014-10-06 17:24:46 UTC) #4
phoglund_chromium
6 years, 2 months ago (2014-10-10 08:49:40 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/644873003/ by phoglund@chromium.org.

The reason for reverting is: Should be fixed by
https://codereview.chromium.org/638423002/ and
https://codereview.chromium.org/640253002..

Powered by Google App Engine
This is Rietveld 408576698