Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 630103002: Move RenderSVGResource::cast() to RenderSVGResourceContainer (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Move RenderSVGResource::cast() to RenderSVGResourceContainer Only use with/called on the latter. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
6 years, 2 months ago (2014-10-06 16:21:59 UTC) #2
pdr.
On 2014/10/06 at 16:21:59, fs wrote: > LGTM As a followup: Can we remove this ...
6 years, 2 months ago (2014-10-07 02:41:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630103002/1
6 years, 2 months ago (2014-10-07 10:35:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183323
6 years, 2 months ago (2014-10-07 10:39:09 UTC) #6
fs
6 years, 2 months ago (2014-10-07 14:34:31 UTC) #7
Message was sent while issue was closed. 
On 2014/10/07 02:41:02, pdr wrote:
> As a followup: Can we remove this entirely? It should be redundant with the
> DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS below.

Not quite sure this (getRenderSVGResourceById) mixes too well with the
macro-defined casts (token-pasting vs. templates). I uploaded
https://codereview.chromium.org/631233002 though, so feel free to elaborate
there.

Powered by Google App Engine
This is Rietveld 408576698