runtime/vm/simulator_arm64.h - Issue 630093004: Fix 32-bit and 64-bit carry out calculation in arm64 simulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_arm64.h

Issue 630093004: Fix 32-bit and 64-bit carry out calculation in arm64 simulator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/simulator_arm64.h

===================================================================

--- runtime/vm/simulator_arm64.h (revision 40988)

+++ runtime/vm/simulator_arm64.h (working copy)

@@ -175,14 +175,11 @@

// Helper functions to set the conditional flags in the architecture state.

void SetNZFlagsW(int32_t val);

- bool CarryFromW(int32_t left, int32_t right);

- bool BorrowFromW(int32_t left, int32_t right);

- bool OverflowFromW(

- int32_t alu_out, int32_t left, int32_t right, bool addition);

+ bool CarryFromW(int32_t left, int32_t right, int32_t carry);

+ bool OverflowFromW(int32_t left, int32_t right, int32_t carry);

void SetNZFlagsX(int64_t val);

- bool CarryFromX(int64_t left, int64_t right);

- bool BorrowFromX(int64_t left, int64_t right);

+ bool CarryFromX(int64_t alu_out, int64_t left, int64_t right, bool addition);

bool OverflowFromX(

int64_t alu_out, int64_t left, int64_t right, bool addition);

« no previous file with comments | « runtime/vm/disassembler_arm64.cc ('k') | runtime/vm/simulator_arm64.cc » ('j') | no next file with comments »