Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: runtime/vm/disassembler_arm64.cc

Issue 630093004: Fix 32-bit and 64-bit carry out calculation in arm64 simulator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/disassembler_arm64.cc
===================================================================
--- runtime/vm/disassembler_arm64.cc (revision 40955)
+++ runtime/vm/disassembler_arm64.cc (working copy)
@@ -914,6 +914,23 @@
}
+void ARM64Decoder::DecodeAddSubWithCarry(Instr* instr) {
+ switch (instr->Bit(30)) {
+ case 0: {
+ Format(instr, "adc'sf's 'rd, 'rn, 'rm");
+ break;
+ }
+ case 1: {
+ Format(instr, "sbc'sf's 'rd, 'rn, 'rm");
+ break;
+ }
+ default:
+ UNREACHABLE();
+ break;
+ }
+}
+
+
void ARM64Decoder::DecodeLogicalShift(Instr* instr) {
const int op = (instr->Bits(29, 2) << 1) | instr->Bit(21);
switch (op) {
@@ -1019,6 +1036,8 @@
void ARM64Decoder::DecodeDPRegister(Instr* instr) {
if (instr->IsAddSubShiftExtOp()) {
DecodeAddSubShiftExt(instr);
+ } else if (instr->IsAddSubWithCarryOp()) {
+ DecodeAddSubWithCarry(instr);
} else if (instr->IsLogicalShiftOp()) {
DecodeLogicalShift(instr);
} else if (instr->IsMiscDP2SourceOp()) {

Powered by Google App Engine
This is Rietveld 408576698