Issue 630093002: fix webtry local run documentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 630093002: fix webtry local run documentation (Closed)

Created:
6 years, 2 months ago by humper

Modified:
6 years, 2 months ago

Reviewers:
tfarina

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

fix webtry local run documentation BUG=skia: Committed: https://skia.googlesource.com/skia/+/d3b7ef6c2b62f0ccaf2c1ed56cf1d4371708728b

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	experimental/webtry/README.md	View		1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

humper

Committed patchset #1 (id:1) manually as d3b7ef6c2b62f0ccaf2c1ed56cf1d4371708728b (presubmit successful).

6 years, 2 months ago (2014-10-06 16:05:06 UTC) #1

tfarina

6 years, 2 months ago (2014-10-06 16:12:57 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/630093002/diff/1/experimental/webtry/README.md
File experimental/webtry/README.md (left):

https://codereview.chromium.org/630093002/diff/1/experimental/webtry/README.m...
experimental/webtry/README.md:12: $ GYP_GENERATORS=ninja ./gyp_skia
gyp/webtry.gyp gyp/most.gyp -Dskia_gpu=0
How are the user going to build the C++ part? "build" script below does not run
this. I don't think removing this part is good, unless I'm missing something.

Could you explain this part? Who is doing it now?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages