Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 630023002: Remove FLAG_opt_safe_uint32_operations. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_IA32 9 #if V8_TARGET_ARCH_IA32
10 10
(...skipping 721 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 if (instr->representation().IsSmi() && constant_value > 0) { 732 if (instr->representation().IsSmi() && constant_value > 0) {
733 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToSmi); 733 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToSmi);
734 } 734 }
735 } else { 735 } else {
736 right = UseFixed(right_value, ecx); 736 right = UseFixed(right_value, ecx);
737 } 737 }
738 738
739 // Shift operations can only deoptimize if we do a logical shift by 0 and 739 // Shift operations can only deoptimize if we do a logical shift by 0 and
740 // the result cannot be truncated to int32. 740 // the result cannot be truncated to int32.
741 if (op == Token::SHR && constant_value == 0) { 741 if (op == Token::SHR && constant_value == 0) {
742 if (FLAG_opt_safe_uint32_operations) { 742 does_deopt = !instr->CheckFlag(HInstruction::kUint32);
743 does_deopt = !instr->CheckFlag(HInstruction::kUint32);
744 } else {
745 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToInt32);
746 }
747 } 743 }
748 744
749 LInstruction* result = 745 LInstruction* result =
750 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt)); 746 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt));
751 return does_deopt ? AssignEnvironment(result) : result; 747 return does_deopt ? AssignEnvironment(result) : result;
752 } else { 748 } else {
753 return DoArithmeticT(op, instr); 749 return DoArithmeticT(op, instr);
754 } 750 }
755 } 751 }
756 752
(...skipping 1952 matching lines...) Expand 10 before | Expand all | Expand 10 after
2709 LOperand* function = UseRegisterAtStart(instr->function()); 2705 LOperand* function = UseRegisterAtStart(instr->function());
2710 LAllocateBlockContext* result = 2706 LAllocateBlockContext* result =
2711 new(zone()) LAllocateBlockContext(context, function); 2707 new(zone()) LAllocateBlockContext(context, function);
2712 return MarkAsCall(DefineFixed(result, esi), instr); 2708 return MarkAsCall(DefineFixed(result, esi), instr);
2713 } 2709 }
2714 2710
2715 2711
2716 } } // namespace v8::internal 2712 } } // namespace v8::internal
2717 2713
2718 #endif // V8_TARGET_ARCH_IA32 2714 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698