Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 630013002: Replacing the OVERRIDE with override in /src/url (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, jshin+watch_chromium.org, MRV, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override in /src/url This step is a giant search and replace for OVERRIDE with their lowercase versions. BUG=417463 Committed: https://crrev.com/3253b57271e643e4e0524b94fa278d4582a0ccca Cr-Commit-Position: refs/heads/master@{#298416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M url/url_canon_icu.h View 1 chunk +1 line, -1 line 0 comments Download
M url/url_canon_stdstring.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 12:51:14 UTC) #2
brettw
lgtm
6 years, 2 months ago (2014-10-06 16:50:59 UTC) #3
anujsharma
On 2014/10/06 16:50:59, brettw wrote: > lgtm Thanks brettw for lgtm.
6 years, 2 months ago (2014-10-07 02:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630013002/1
6 years, 2 months ago (2014-10-07 02:38:21 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 04:43:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630013002/1
6 years, 2 months ago (2014-10-07 07:30:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as a8ecdd1713ce7f95bb60da4a8d4eb4aca96b123a
6 years, 2 months ago (2014-10-07 07:31:08 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 07:31:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3253b57271e643e4e0524b94fa278d4582a0ccca
Cr-Commit-Position: refs/heads/master@{#298416}

Powered by Google App Engine
This is Rietveld 408576698