Issue 630002: Allow the Mac theme provider to give default colors/tints if requested.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 630002: Allow the Mac theme provider to give default colors/tints if requested. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 3 months ago by Avi

Modified:
4 years ago

Reviewers:
pink, Nico, Miranda Callahan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow the Mac theme provider to give default colors/tints if requested. Switch the download shelf's "open downloads" link to directly use the theme provider. BUG=http://crbug.com/35554 TEST=no visible change in normal mode; incognito mode still being worked on Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39279

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -82 lines)			Patch
M	app/theme_provider.h	View	1 chunk	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.h	View	4 chunks	+17 lines, -4 lines	1 comment	Download
M	chrome/browser/browser_theme_provider.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_theme_provider_mac.mm	View	4 chunks	+69 lines, -29 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/cocoa/browser_theme_provider_init.mm	View	5 chunks	+13 lines, -18 lines	0 comments	Download
M	chrome/browser/cocoa/download_shelf_controller.mm	View	4 chunks	+14 lines, -22 lines	0 comments	Download

Trybot results: linux win mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi

This is a continuation from http://codereview.chromium.org/611001 ; I dunno why gcl decided to make a ...

5 years, 3 months ago (2010-02-17 21:27:36 UTC) #1

Miranda Callahan

Yes, LGTM, looks like it will work great. Thanks!

5 years, 3 months ago (2010-02-17 22:12:58 UTC) #2

Nico

5 years, 3 months ago (2010-02-17 22:22:40 UTC) #3

http://codereview.chromium.org/630002/diff/5001/5003
File chrome/browser/browser_theme_provider.h (right):

http://codereview.chromium.org/630002/diff/5001/5003#newcode121
chrome/browser/browser_theme_provider.h:121: virtual NSImage*
GetNSImageNamed(int id, bool allow_default) const;
How about using an enum instead of a bool? Makes the calling sites nicer:

  frobonator->GetNSImageNamed(theImage, kDefaultImage);
  frobonator->GetNSImageNamed(theImage, kDefaultAsNull);

Expand Messages | Collapse Messages