Adjust bookmark folder menu window if its parent button is partly off-screen to the left.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
index 2eb0880c5f79ed46df5d53ad068412a2a6691471..b9a69193732358a5a71a2154e09db0bd335e38f5 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
@@ -558,6 +558,12 @@ NSRect GetFirstButtonFrameForHeight(CGFloat height) {
     newWindowTopLeft.y = topOfWindow.y +
                          2 * bookmarks::kBookmarkVerticalPadding;
   }
+
+  // If parent button was partially off screen to the left, offset it's folder
+  // menu window horizontally, so that complete menu is seen from the left.
+  if (newWindowTopLeft.x < 0.0)

[Alexei Svitkine (slow), 2014/10/06 17:55:28]

Are you sure this is correct?

What if the user has two monitors and the main monitor (with the menu bar) is to
right of the secondary monitor? And the user's Chrome window is on the second
screen (on the left).

I suspect that this will result in the coordinates being negative but not
needing adjustment.

Can you verify that case?

[Gaja, 2014/10/07 07:41:10]

Oh, I did not think of it. But I have a doubt here.

If the button is partially off screen on the right, its menu is shown completely
i.e it is adjusted such that its full width is seen.
If user has two monitors and secondary monitor is on to the right of main
monitor, in this case the menu shares both the screens?

I do not have multi monitor setup to verify :(

I will use the logic written to handle on the right side, and upload the changes
in patch set 2.

+    newWindowTopLeft.x = 0.0;
+
   return newWindowTopLeft;
 }