Adjust bookmark folder menu window if its parent button is partly off-screen to the left.

Adjust bookmark folder menu window if its parent button is partly off-screen to the left.

When parent button is partly offscreen to the left, its folder menu's top left
aligns with its parent button's top left which makes window not completely to see.
This case is handled for right side. This CL applies the same logic for left side.

BUG=309668
R=asvitkine@chromium.org

TEST=
1. Create a folder on Bookmark Bar with some bookmarks in it
2. Move the chrome window out of the view (left side of the screen), so that the folder is partly off screen
3. Click on the folder to open its menu and observe
4. The folder menu should be seen completely from left

Committed: https://crrev.com/27bbd979735c75aae5bbdefabfc9d3f3c811bef8
Cr-Commit-Position: refs/heads/master@{#298738}

[Gaja, 2014-10-06 12:14:58]

PTAL.

[Alexei Svitkine (slow), 2014-10-06 17:55:28]

https://codereview.chromium.org/629973002/diff/1/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

https://codereview.chromium.org/629973002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:564: if
(newWindowTopLeft.x < 0.0)
Are you sure this is correct?

What if the user has two monitors and the main monitor (with the menu bar) is to
right of the secondary monitor? And the user's Chrome window is on the second
screen (on the left).

I suspect that this will result in the coordinates being negative but not
needing adjustment.

Can you verify that case?

[Gaja, 2014-10-07 07:41:11]

@asvitkine
Please take a look at patch set 2. 
I have applied the same logic as how it is handled on right side.

https://codereview.chromium.org/629973002/diff/1/chrome/browser/ui/cocoa/book...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

https://codereview.chromium.org/629973002/diff/1/chrome/browser/ui/cocoa/book...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:564: if
(newWindowTopLeft.x < 0.0)
On 2014/10/06 17:55:28, Alexei Svitkine wrote:
> Are you sure this is correct?
> 
> What if the user has two monitors and the main monitor (with the menu bar) is
to
> right of the secondary monitor? And the user's Chrome window is on the second
> screen (on the left).
> 
> I suspect that this will result in the coordinates being negative but not
> needing adjustment.
> 
> Can you verify that case?

Oh, I did not think of it. But I have a doubt here.

If the button is partially off screen on the right, its menu is shown completely
i.e it is adjusted such that its full width is seen.
If user has two monitors and secondary monitor is on to the right of main
monitor, in this case the menu shares both the screens?

I do not have multi monitor setup to verify :(

I will use the logic written to handle on the right side, and upload the changes
in patch set 2.

[Alexei Svitkine (slow), 2014-10-07 18:26:13]

https://codereview.chromium.org/629973002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

https://codereview.chromium.org/629973002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:538: } else
{ // For left side.
Nit: Two spaces before start of // comment.

https://codereview.chromium.org/629973002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:540: if
(spillOff > 0.0)
Just check "if (newWindowTopLeft.x < NSMinX(screenFrame))" instead of re-using
spillOff. Then, you can make it an "else if" and put the comment inside the
block.

[Gaja, 2014-10-08 03:08:03]

Changes in patch set #3. PTAL.

https://codereview.chromium.org/629973002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
(right):

https://codereview.chromium.org/629973002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:538: } else
{ // For left side.
On 2014/10/07 18:26:13, Alexei Svitkine wrote:
> Nit: Two spaces before start of // comment.

Moved to else if block.

https://codereview.chromium.org/629973002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm:540: if
(spillOff > 0.0)
On 2014/10/07 18:26:13, Alexei Svitkine wrote:
> Just check "if (newWindowTopLeft.x < NSMinX(screenFrame))" instead of re-using
> spillOff. Then, you can make it an "else if" and put the comment inside the
> block.

Done.

[Alexei Svitkine (slow), 2014-10-08 14:49:40]

lgtm

[Gaja, 2014-10-08 16:51:42]

The CQ bit was checked by gajendra.n@samsung.com

[commit-bot: I haz the power, 2014-10-08 16:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629973002/40001

[commit-bot: I haz the power, 2014-10-08 17:25:23]

Committed patchset #3 (id:40001) as 49be3c6a52aa338c70761640cdc0777f9b23c7cf

[commit-bot: I haz the power, 2014-10-08 17:26:02]

Patchset 3 (id:??) landed as
https://crrev.com/27bbd979735c75aae5bbdefabfc9d3f3c811bef8
Cr-Commit-Position: refs/heads/master@{#298738}