Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 629963002: Replacing the OVERRIDE with override and FINAL with final in content/browser/media (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/media This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/96a68d505f4e607a77b6d65d4b9a357630e325d7 Cr-Commit-Position: refs/heads/master@{#298258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -136 lines) Patch
M content/browser/media/android/browser_demuxer_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/android/browser_demuxer_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 chunk +14 lines, -14 lines 0 comments Download
M content/browser/media/android/media_resource_getter_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/media/audio_stream_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_audio_input_stream.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/media/capture/web_contents_audio_input_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_audio_muter.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/media/capture/web_contents_tracker.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 9 chunks +23 lines, -23 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/media/media_internals_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_internals_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_web_contents_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/midi_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/midi_host.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/media/webrtc_internals.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/media/webrtc_internals_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals_message_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_internals_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 13:06:34 UTC) #2
Avi (use Gerrit)
On 2014/10/06 13:06:34, MRV wrote: > PTAL Stampity stamp LGTM
6 years, 2 months ago (2014-10-06 15:00:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629963002/1
6 years, 2 months ago (2014-10-06 15:42:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3074287abc94c7677a5d22f8c3fef470ca727792
6 years, 2 months ago (2014-10-06 17:19:05 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 17:20:13 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/96a68d505f4e607a77b6d65d4b9a357630e325d7
Cr-Commit-Position: refs/heads/master@{#298258}

Powered by Google App Engine
This is Rietveld 408576698