Check if there is still time before finalizing an incremental collection.

src/heap/gc-idle-time-handler.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_GC_IDLE_TIME_HANDLER_H_
 #define V8_HEAP_GC_IDLE_TIME_HANDLER_H_
 
 #include "src/globals.h"
 
 namespace v8 {
@@ skipping 137 matching lines @@
   }
 
   void NotifyScavenge() { ++scavenges_since_last_idle_round_; }
 
   static size_t EstimateMarkingStepSize(size_t idle_time_in_ms,
                                         size_t marking_speed_in_bytes_per_ms);
 
   static size_t EstimateMarkCompactTime(
       size_t size_of_objects, size_t mark_compact_speed_in_bytes_per_ms);
 
+  static bool DoMarkCompact(size_t idle_time_in_ms, size_t size_of_objects,

[Erik Corry Chromium.org, 2014/10/06 14:56:47]

I would prefer "ShouldDoMarkCompact" to make it clearer that this checks whether
we should do a mark-compact GC, rather than actually doing it.

[Hannes Payer (out of office), 2014/10/07 13:41:11]

Done.

+                            size_t mark_compact_speed_in_bytes_per_ms);
+
   static bool DoScavenge(
       size_t idle_time_in_ms, size_t new_space_size, size_t used_new_space_size,
       size_t scavenger_speed_in_bytes_per_ms,
       size_t new_space_allocation_throughput_in_bytes_per_ms);
 
  private:
   void StartIdleRound() { mark_compacts_since_idle_round_started_ = 0; }
   bool IsMarkCompactIdleRoundFinished() {
     return mark_compacts_since_idle_round_started_ ==
            kMaxMarkCompactsInIdleRound;
   }
   bool EnoughGarbageSinceLastIdleRound() {
     return scavenges_since_last_idle_round_ >= kIdleScavengeThreshold;
   }
 
   int mark_compacts_since_idle_round_started_;
   int scavenges_since_last_idle_round_;
 
   DISALLOW_COPY_AND_ASSIGN(GCIdleTimeHandler);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_GC_IDLE_TIME_HANDLER_H_