Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 629883003: Replacing the OVERRIDE with override and FINAL with final in /src/dbus (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, MRV, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in /src/dbus This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/1a60a65835b7189dca67332134391f3a325e2047 Cr-Commit-Position: refs/heads/master@{#298415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M dbus/bus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M dbus/dbus_statistics_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M dbus/mock_object_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M dbus/object_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M dbus/object_proxy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/test_service.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-06 07:28:20 UTC) #2
stevenjb
We should either be using TBR for bulk search/replace of this sort of thing, or ...
6 years, 2 months ago (2014-10-06 18:13:38 UTC) #3
stevenjb
On 2014/10/06 18:13:38, stevenjb wrote: > We should either be using TBR for bulk search/replace ...
6 years, 2 months ago (2014-10-06 18:13:55 UTC) #4
anujsharma
On 2014/10/06 18:13:55, stevenjb wrote: > On 2014/10/06 18:13:38, stevenjb wrote: > > We should ...
6 years, 2 months ago (2014-10-07 02:43:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629883003/1
6 years, 2 months ago (2014-10-07 02:49:15 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 04:53:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629883003/1
6 years, 2 months ago (2014-10-07 07:28:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0dc8aba2efbb4702dddd684eef7708a1e64530bb
6 years, 2 months ago (2014-10-07 07:30:02 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 07:31:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a60a65835b7189dca67332134391f3a325e2047
Cr-Commit-Position: refs/heads/master@{#298415}

Powered by Google App Engine
This is Rietveld 408576698