Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3697)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 62983004: -Wunused-functions for linux, android, chromeos (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/performance_monitor/performance_monitor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index ea4ac510a6dec52e578a38e84ff8b94b2ce38cc1..67695c6facfb3831a63153e9a265bcbdcca3e6aa 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -214,16 +214,17 @@ static void AddPattern(URLPatternSet* extent, const std::string& pattern) {
}
#endif
+#if !(defined(OS_LINUX) && defined(USE_AURA) && !defined(OS_CHROMEOS))
base::FilePath GetTemporaryFile() {
base::FilePath temp_file;
CHECK(file_util::CreateTemporaryFile(&temp_file));
return temp_file;
}
-
bool WaitForCountNotificationsCallback(int *count) {
return --(*count) == 0;
}
+#endif // !(defined(OS_LINUX) && defined(USE_AURA) && !defined(OS_CHROMEOS))
} // namespace
@@ -1303,7 +1304,7 @@ void PackExtensionTestClient::OnPackFailure(const std::string& error_message,
// TODO(aura): http://crbug.com/316919
//
-// The ExetnsionServiceTest reliably has some tests fail on each run, except
+// The ExtensionServiceTest reliably has some tests fail on each run, except
// that they're different tests each time. The problem appears to be that
// another thread is holding a lock while ShadowingAtExitManager destroys all
// LazyInstances<>. Something very bad is going on with threading here.
@@ -3126,7 +3127,7 @@ TEST_F(ExtensionServiceTest, LoadExtensionsWithPlugins) {
EXPECT_EQ(2u, service_->extensions()->size());
EXPECT_EQ(0u, service_->disabled_extensions()->size());
}
-#endif
+#endif // !defined(OS_CHROMEOS)
namespace {
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/performance_monitor/performance_monitor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698