Source/web/WebPluginContainerImpl.cpp - Issue 629823002: Keyboard Shortkey for ctrl+insert is not working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 629823002: Keyboard Shortkey for ctrl+insert is not working. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changes for meta key in mac os. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPluginContainerImpl.cpp

diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp

index d93a9df6457773ad727018c1bf59805a0f89fc63..f01fdfe45a2fec4129e82a083cca962a15ced5a0 100644

--- a/Source/web/WebPluginContainerImpl.cpp

+++ b/Source/web/WebPluginContainerImpl.cpp

@@ -819,7 +819,7 @@ void WebPluginContainerImpl::handleKeyboardEvent(KeyboardEvent* event)

#else

if (webEvent.modifiers == WebInputEvent::ControlKey

#endif

- && webEvent.windowsKeyCode == VKEY_C

+ && (webEvent.windowsKeyCode == VKEY_C || webEvent.windowsKeyCode == VKEY_INSERT)

// Only copy if there's a selection, so that we only ever do this

// for Pepper plugins that support copying. Windowless NPAPI

// plugins will get the event as before.

« no previous file with comments | « no previous file | Source/web/tests/WebPluginContainerTest.cpp » ('j') | no next file with comments »