crash_collector.cc - Issue 6297004: crash-reporter: Add diagnostics to help diagnose failures in the wild

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crash_collector.cc

Issue 6297004: crash-reporter: Add diagnostics to help diagnose failures in the wild (Closed) Base URL: http://git.chromium.org/git/crash-reporter.git@master

Patch Set: respond to review Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crash_collector.cc

diff --git a/crash_collector.cc b/crash_collector.cc

index 89fe41de46cf2c81ab6b65472fa137f42317f654..afd72d1e129757c3a5f992abac0171d47d826057 100644

--- a/crash_collector.cc

+++ b/crash_collector.cc

@@ -110,7 +110,8 @@ int CrashCollector::ForkExecAndPipe(std::vector<const char *> &arguments,

}

if (pid == 0) {

- int output_handle = HANDLE_EINTR(creat(output_file, 0600));

+ int output_handle = HANDLE_EINTR(

+ open(output_file, O_CREAT | O_WRONLY | O_TRUNC | O_EXCL, 0666));

if (output_handle < 0) {

logger_->LogError("Could not create %s: %d", output_file, errno);

// Avoid exit() to avoid atexit handlers from parent.

« no previous file with comments | « crash_collector.h ('k') | crash_collector_test.cc » ('j') | no next file with comments »