dom-ui settings: enable languages & spell checker settings for all platforms....

chrome/browser/resources/options/language_list.js

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.language', function() {
   const ArrayDataModel = cr.ui.ArrayDataModel;
   const LanguageOptions = options.LanguageOptions;
   const List = cr.ui.List;
   const ListItem = cr.ui.ListItem;
   const ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
@@ skipping 73 matching lines @@
 
     /** @inheritDoc */
     decorate: function() {
       List.prototype.decorate.call(this);
       this.selectionModel = new ListSingleSelectionModel;
 
       // HACK(arv): http://crbug.com/40902
       window.addEventListener('resize', this.redraw.bind(this));
 
       // Listen to pref change.
-      Preferences.getInstance().addEventListener(this.preferredLanguagesPref,
-          this.handlePreferredLanguagesPrefChange_.bind(this));
+      if (cr.isChromeOS) {
+        Preferences.getInstance().addEventListener(this.preferredLanguagesPref,
+            this.handlePreferredLanguagesPrefChange_.bind(this));
+      } else {
+        Preferences.getInstance().addEventListener(this.acceptLanguagesPref,
+            this.handleAcceptLanguagesPrefChange_.bind(this));
+      }
 
       // Listen to drag and drop events.
       this.addEventListener('dragstart', this.handleDragStart_.bind(this));
       this.addEventListener('dragenter', this.handleDragEnter_.bind(this));
       this.addEventListener('dragover', this.handleDragOver_.bind(this));
       this.addEventListener('drop', this.handleDrop_.bind(this));
     },
 
     createItem: function(languageCode) {
       var languageDisplayName =
@@ skipping 70 matching lines @@
      * @param {Event} e The dragstart event.
      * @private
      */
     handleDragStart_: function(e) {
       var target = e.target;
       // ListItem should be the only draggable element type in the page,
       // but just in case.
       if (target instanceof ListItem) {
         this.draggedItem = target;
         e.dataTransfer.effectAllowed = 'move';
+        // We need to put some kind of data in the drag or it will be
+        // ignored.  Use the display name in case the user drags to a text
+        // field or the desktop.
+        e.dataTransfer.setData('text/plain', target.title);
       }
     },
 
     /*
      * Handles the dragenter event.
      * @param {Event} e The dragenter event.
      * @private
      */
     handleDragEnter_: function(e) {
       e.preventDefault();
@@ skipping 52 matching lines @@
      * @private
      */
     handlePreferredLanguagesPrefChange_: function(e) {
       var languageCodesInCsv = e.value.value;
       var languageCodes = this.filterBadLanguageCodes_(
           languageCodesInCsv.split(','));
       this.load_(languageCodes);
     },
 
     /**
+     * Handles accept languages pref change.
+     * @param {Event} e The change event object.
+     * @private
+     */
+    handleAcceptLanguagesPrefChange_: function(e) {
+      var languageCodesInCsv = e.value.value;
+      var languageCodes = this.filterBadLanguageCodes_(
+          languageCodesInCsv.split(','));
+      this.load_(languageCodes);
+    },
+
+    /**
      * Loads given language list.
      * @param {Array} languageCodes List of language codes.
      * @private
      */
     load_: function(languageCodes) {
       // Preserve the original selected index. See comments below.
       var originalSelectedIndex = (this.selectionModel ?
                                    this.selectionModel.selectedIndex : -1);
       this.dataModel = new ArrayDataModel(languageCodes);
       if (originalSelectedIndex >= 0 &&
@@ skipping 10 matching lines @@
         // automatically, hence we manually select the first item here.
         this.selectionModel.selectedIndex = 0;
       }
     },
 
     /**
      * Saves the preference.
      */
     savePreference_: function() {
       // Encode the language codes into a CSV string.
-      Preferences.setStringPref(this.preferredLanguagesPref,
-                                this.dataModel.slice().join(','));
+      if (cr.isChromeOS)
+        Preferences.setStringPref(this.preferredLanguagesPref,
+                                  this.dataModel.slice().join(','));
       // Save the same language list as accept languages preference as
       // well, but we need to expand the language list, to make it more
       // acceptable. For instance, some web sites don't understand 'en-US'
       // but 'en'. See crosbug.com/9884.
       var acceptLanguages = this.expandLanguageCodes(this.dataModel.slice());
       Preferences.setStringPref(this.acceptLanguagesPref,
                                 acceptLanguages.join(','));
       cr.dispatchSimpleEvent(this, 'save');
     },
 
@@ skipping 41 matching lines @@
         }
       }
       return filteredLanguageCodes;
     },
   };
 
   return {
     LanguageList: LanguageList
   };
 });