Source/web/tests/ScrollingCoordinatorChromiumTest.cpp - Issue 629583002: Make compositor and blink talk in fractional scroll offset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

Issue 629583002: Make compositor and blink talk in fractional scroll offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

diff --git a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

index c6d46af9f77c5ab0a038a45046e86eae63239205..d5e412a5d29e90f67bc70e9a7cfd14a7e26885a4 100644

--- a/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

+++ b/Source/web/tests/ScrollingCoordinatorChromiumTest.cpp

@@ -462,7 +462,7 @@ TEST_F(ScrollingCoordinatorChromiumTest, rtlIframe)

ASSERT_TRUE(webScrollLayer->scrollable());

int expectedScrollPosition = 958 + (innerFrameView->verticalScrollbar()->isOverlayScrollbar() ? 0 : 15);

- ASSERT_EQ(expectedScrollPosition, webScrollLayer->scrollPosition().x);

+ ASSERT_EQ(expectedScrollPosition, webScrollLayer->scrollPositionDouble().x);

}

TEST_F(ScrollingCoordinatorChromiumTest, setupScrollbarLayerShouldNotCrash)

« no previous file with comments | « Source/platform/graphics/GraphicsLayerTest.cpp ('k') | public/platform/WebDoublePoint.h » ('j') | no next file with comments »