LayoutTests/fast/scrolling/fractional-scroll-offset-document.html - Issue 629583002: Make compositor and blink talk in fractional scroll offset

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/scrolling/fractional-scroll-offset-document.html

Issue 629583002: Make compositor and blink talk in fractional scroll offset (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>
	Rick Byers 2014/10/04 00:04:24 nit: omit <html> tag nit: omit <html> tag Yufeng Shen (Slow to review) 2014/10/06 17:54:58 Done. Show quoted text On 2014/10/04 00:04:24, Rick Byers wrote: > nit: omit <html> tag Done.
	3 <body style="width:30000px;height:30000px" onload="runTest()">

	4 </body>

	5

	6 <script src="../../resources/js-test.js"></script>

	7 <script>

	8 description("Verifies that document scrolling supports fractional offset.");

	9

	10 var floatPrecision = 0.00001;

	11 function checkScrollOffset(offset_x, offset_y)

	12 {

	13 if (window.eventSender) {
	Rick Byers 2014/10/04 00:04:24 nit: remove this check. We'll never hit this func nit: remove this check. We'll never hit this function if eventSender isn't defined (will throw in scroll). Yufeng Shen (Slow to review) 2014/10/06 17:54:57 Done. Show quoted text On 2014/10/04 00:04:24, Rick Byers wrote: > nit: remove this check. We'll never hit this function if eventSender isn't > defined (will throw in scroll). Done.
	14 shouldBeCloseTo('document.documentElement.scrollTop', offset_y, floatPre cision);

	15 shouldBeCloseTo('document.documentElement.scrollLeft', offset_x, floatPr ecision);

	16 }

	17 }

	18

	19 function scroll()

	20 {

	21 eventSender.gestureScrollBegin(100.1, 300.2);

	22 checkScrollOffset(0, 0);

	23 eventSender.gestureScrollUpdate(-20.5, -10.2);

	24 checkScrollOffset(20.5, 10.2);

	25 eventSender.gestureScrollUpdate(10.9, -20.9);

	26 checkScrollOffset(9.6, 31.1);

	27 eventSender.gestureScrollUpdate(100.4, 220.9);

	28 checkScrollOffset(0.0, 0.0);

	29 eventSender.gestureScrollEnd(0, 0);

	30

	31 isSuccessfullyParsed();

	32 if (window.testRunner)

	33 testRunner.notifyDone();
	Rick Byers 2014/10/04 00:04:24 You should be able to remove these three lines. T You should be able to remove these three lines. This is a synchronous test, so no need for notifyDone. And js-test.js does the 'isSuccessfullyParsed' for you. Yufeng Shen (Slow to review) 2014/10/06 17:54:57 Done. Show quoted text On 2014/10/04 00:04:24, Rick Byers wrote: > You should be able to remove these three lines. This is a synchronous test, so > no need for notifyDone. And js-test.js does the 'isSuccessfullyParsed' for you. Done. Rick Byers 2014/10/06 21:11:30 remove isSuccessfullyParsed too - that should be r Show quoted text On 2014/10/06 17:54:57, Yufeng Shen wrote: > On 2014/10/04 00:04:24, Rick Byers wrote: > > You should be able to remove these three lines. This is a synchronous test, > so > > no need for notifyDone. And js-test.js does the 'isSuccessfullyParsed' for > you. > > Done. remove isSuccessfullyParsed too - that should be redundant (and is generally left to js-test).
	34 }

	35

	36 function runTest()

	37 {

	38 if (window.eventSender)

	39 scroll();

	40 }

	41

	42 </script>

	43 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/scrolling/fractional-scroll-offset-document-expected.txt » ('j') | Source/platform/graphics/GraphicsLayer.cpp » ('J')