Add Ninja support for MSVS $(TargetExt), $(TargetFileName) and $(TargetPath) macros.

Add Ninja support for MSVS $(TargetExt), $(TargetFileName) and $(TargetPath) macros.

BUG=gyp:462
R=scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1988

[chrisha, 2014-10-03 22:08:06]

chrisha@chromium.org changed reviewers:
+ scottmg@chromium.org

[chrisha, 2014-10-03 22:08:06]

PTAL

(This was the cause of the problems I was seeing with PDB build rules; we
specify our PDB names using these macros.)

[scottmg, 2014-10-03 22:19:59]

https://codereview.chromium.org/629543002/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/629543002/diff/1/pylib/gyp/msvs_emulation.py#...
pylib/gyp/msvs_emulation.py:188: # A dictionary of default target extensions by
type.
this is very similar to MSVSUtil.py, could it reuse that instead?

[scottmg, 2014-10-03 22:21:00]

Was there a bug=?

Otherwise, LGTM with the default extensions refactored.

[chrisha, 2014-10-06 13:40:50]

Added a bug, and refactored the various pieces of extension-computing code to
refer to the same centrally located dictionary.

https://codereview.chromium.org/629543002/diff/1/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/629543002/diff/1/pylib/gyp/msvs_emulation.py#...
pylib/gyp/msvs_emulation.py:188: # A dictionary of default target extensions by
type.
On 2014/10/03 22:19:59, scottmg wrote:
> this is very similar to MSVSUtil.py, could it reuse that instead?

Indeed it is. Removed it from here, and reused the MSVSUtil.TARGET_TYPE_EXT.
Also replaced another similar dictionary being used in the ninja generator.

[chrisha, 2014-10-06 14:16:15]

Thanks, committing.

[chrisha, 2014-10-06 14:18:14]

Committed patchset #2 (id:20001) manually as 1988.

[scottmg, 2014-10-06 17:03:25]

Thanks, LGTM.