Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: build/android/pylib/perf/setup.py

Issue 62953024: [Telemetry] Refactor common Android cleanup functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/perf/setup.py
diff --git a/build/android/pylib/perf/setup.py b/build/android/pylib/perf/setup.py
index d6a5304a06962b74f6657538fa94505803985a02..e8c1cf47246abeada4164a8228402aeb31291b2e 100644
--- a/build/android/pylib/perf/setup.py
+++ b/build/android/pylib/perf/setup.py
@@ -13,43 +13,13 @@ import signal
import shutil
import time
-from pylib import android_commands
-from pylib import cmd_helper
from pylib import constants
from pylib import forwarder
-from pylib import ports
+from pylib.utils import test_environment
import test_runner
-def _KillPendingServers():
- for retry in range(5):
- for server in ['lighttpd', 'web-page-replay']:
- pids = [p.pid for p in psutil.process_iter() if server in p.name]
- for pid in pids:
- try:
- logging.warning('Killing %s %s', server, pid)
- os.kill(pid, signal.SIGQUIT)
- except Exception as e:
- logging.warning('Failed killing %s %s %s', server, pid, e)
- # Restart the adb server with taskset to set a single CPU affinity.
- cmd_helper.RunCmd([constants.ADB_PATH, 'kill-server'])
- cmd_helper.RunCmd(['taskset', '-c', '0', constants.ADB_PATH, 'start-server'])
- cmd_helper.RunCmd(['taskset', '-c', '0', constants.ADB_PATH, 'root'])
- i = 1
- while not android_commands.GetAttachedDevices():
- time.sleep(i)
- i *= 2
- if i > 10:
- break
- # Reset the test port allocation. It's important to do it before starting
- # to dispatch any step.
- if not ports.ResetTestServerPortAllocation():
- raise Exception('Failed to reset test server port.')
-
- forwarder.Forwarder.UseMultiprocessing()
-
-
def Setup(test_options):
"""Create and return the test runner factory and tests.
@@ -66,7 +36,9 @@ def Setup(test_options):
os.makedirs(constants.PERF_OUTPUT_DIR)
# Before running the tests, kill any leftover server.
- _KillPendingServers()
+ logging.info('Restarting adb and waiting for device.')
+ test_environment.CleanupPendingProcesses(restart_adb_as_root=True)
+ forwarder.Forwarder.UseMultiprocessing()
if test_options.single_step:
# Running a single command, build the tests structure.
« no previous file with comments | « no previous file | build/android/pylib/utils/test_environment.py » ('j') | build/android/pylib/utils/test_environment.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698