Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 62953020: Added UMA to track ExtensionService::Init time. (Closed)

Created:
7 years, 1 month ago by benwells
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, jeremy
Visibility:
Public.

Description

Added UMA to track ExtensionService::Init time. This functions is called every time a profile is loaded, including during startup. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235679

Patch Set 1 #

Patch Set 2 : Correct histograms.xml file #

Total comments: 2

Patch Set 3 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
benwells
koz for sanity
7 years, 1 month ago (2013-11-14 03:08:33 UTC) #1
koz (OOO until 15th September)
lgtm https://codereview.chromium.org/62953020/diff/30001/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): https://codereview.chromium.org/62953020/diff/30001/chrome/browser/extensions/extension_service.cc#newcode593 chrome/browser/extensions/extension_service.cc:593: UMA_HISTOGRAM_TIMES("Extensions.ExtensionServiceInit", It's common to have a Time suffix ...
7 years, 1 month ago (2013-11-14 03:41:24 UTC) #2
benwells
+cc jeremy fyi +jar for histograms
7 years, 1 month ago (2013-11-15 00:08:32 UTC) #3
jar (doing other things)
histograms.xml LGTM
7 years, 1 month ago (2013-11-15 06:31:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/62953020/80001
7 years, 1 month ago (2013-11-15 07:47:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=224974
7 years, 1 month ago (2013-11-15 09:37:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/62953020/80001
7 years, 1 month ago (2013-11-18 06:01:59 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 09:32:26 UTC) #8
Message was sent while issue was closed.
Change committed as 235679

Powered by Google App Engine
This is Rietveld 408576698