Issue 62953015: Add an untrusted NaCl build target for jsoncpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62953015: Add an untrusted NaCl build target for jsoncpp. (Closed)

Created:
7 years, 1 month ago by Peter Lundblad

Modified:
7 years, 1 month ago

Reviewers:
Ronghua Wu (Left Chromium), Mallinath (Gone from Chromium)

CC:
chromium-reviews, David Tseng, dmazzoni, bradnelson, noelallen1

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -31 lines)			Patch
M	third_party/jsoncpp/README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/jsoncpp/jsoncpp.gyp	View		1 chunk	+3 lines, -30 lines	0 comments	Download
A	third_party/jsoncpp/jsoncpp.gypi	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	third_party/jsoncpp/jsoncpp_untrusted.gyp	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Peter Lundblad

Hi, I am adding a thirdparty library that we use in the chromevox extension. It ...

7 years, 1 month ago (2013-11-08 20:51:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/62953015/370001

7 years, 1 month ago (2013-11-08 22:23:30 UTC) #4

Message was sent while issue was closed.

Change committed as 234073