Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 62953004: Support variation params for forcing_flag groups. (Closed)

Created:
7 years, 1 month ago by Alexei Svitkine (slow)
Modified:
7 years, 1 month ago
Reviewers:
jwd
CC:
chromium-reviews
Visibility:
Public.

Description

Support variation params for forcing_flag groups. BUG=315860 TEST=New unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233701

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -22 lines) Patch
M components/variations/variations_associated_data_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/variations/variations_seed_processor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/variations/variations_seed_processor.cc View 3 chunks +14 lines, -8 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 1 14 chunks +45 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
7 years, 1 month ago (2013-11-06 22:55:56 UTC) #1
jwd
lgtm
7 years, 1 month ago (2013-11-07 15:48:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/62953004/530001
7 years, 1 month ago (2013-11-07 15:49:43 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 21:53:12 UTC) #4
Message was sent while issue was closed.
Change committed as 233701

Powered by Google App Engine
This is Rietveld 408576698