Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 629523003: Rename Get to GetProxy (Closed)

Created:
6 years, 2 months ago by sky
Modified:
6 years, 2 months ago
Reviewers:
keybuk, DaveMoore
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename Get to GetProxy mojo::Get() is too easy to conflict with. BUG=none TEST=none R=davemoore@chromium.org TBR=keybuk@chromium.org Committed: https://crrev.com/dafebe67bfde1d352b552016db93d089d6693799 Cr-Commit-Position: refs/heads/master@{#298288}

Patch Set 1 #

Patch Set 2 : fix package fetcher #

Patch Set 3 : fix device #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_connection_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M device/serial/serial_service_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/examples/compositor_app/compositor_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/pepper_container_app/pepper_container_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/sample_app/sample_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/surfaces_app/child_gl_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wget/wget.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/websockethandle_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/weburlloader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/viewport_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_init_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/dynamic_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/external_application_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/external_application_registrar_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/package_manager/package_fetcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
sky
6 years, 2 months ago (2014-10-03 22:35:48 UTC) #1
sky
Sorry for bad description the first time around. Came from another patch.
6 years, 2 months ago (2014-10-03 22:36:45 UTC) #2
DaveMoore
lgtm
6 years, 2 months ago (2014-10-06 16:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629523003/1
6 years, 2 months ago (2014-10-06 16:20:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/22019)
6 years, 2 months ago (2014-10-06 16:35:26 UTC) #7
sky
keybug, I'm TBRing you for a trivial rename.
6 years, 2 months ago (2014-10-06 17:01:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629523003/40001
6 years, 2 months ago (2014-10-06 17:03:02 UTC) #11
keybuk
lgtm
6 years, 2 months ago (2014-10-06 18:27:01 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 099f192ead1ab7f7b906835bf3b091e8dfbd1476
6 years, 2 months ago (2014-10-06 18:55:44 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 19:27:55 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dafebe67bfde1d352b552016db93d089d6693799
Cr-Commit-Position: refs/heads/master@{#298288}

Powered by Google App Engine
This is Rietveld 408576698