Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 629493004: [Cast] Clean-up: Move max_unacked_frames into CongestionControl. (Closed)

Created:
6 years, 2 months ago by miu
Modified:
6 years, 2 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Cast] Clean-up: Move max_unacked_frames into CongestionControl. max_unacked_frames isn't being used anywhere except within CongestionControl now that FrameSender uses media duration to decide whether to drop frames. BUG=404813 Committed: https://crrev.com/641adc1265ca1c6ebadddcfcc0319246b65eefde Cr-Commit-Position: refs/heads/master@{#298551}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -53 lines) Patch
M media/cast/receiver/video_decoder_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/audio_sender.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/cast/sender/congestion_control.h View 2 chunks +4 lines, -1 line 0 comments Download
M media/cast/sender/congestion_control.cc View 1 9 chunks +35 lines, -11 lines 0 comments Download
M media/cast/sender/congestion_control_unittest.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M media/cast/sender/frame_sender.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M media/cast/sender/video_encoder_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M media/cast/sender/video_encoder_impl.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M media/cast/sender/video_encoder_impl_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M media/cast/sender/video_sender.cc View 1 2 chunks +8 lines, -14 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/vp8_encoder.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
miu
PTAL.
6 years, 2 months ago (2014-10-04 01:10:38 UTC) #2
hubbe
lgtm
6 years, 2 months ago (2014-10-06 20:53:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629493004/20001
6 years, 2 months ago (2014-10-07 18:50:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2e31d06c953393c423add673021df35618dfca4c
6 years, 2 months ago (2014-10-07 20:06:26 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 20:07:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/641adc1265ca1c6ebadddcfcc0319246b65eefde
Cr-Commit-Position: refs/heads/master@{#298551}

Powered by Google App Engine
This is Rietveld 408576698