Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 629413002: Revert of Reset accessibility if it gets out of sync. (Closed)

Created:
6 years, 2 months ago by jackhou1
Modified:
6 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reset accessibility if it gets out of sync. (patchset #10 id:180001 of https://codereview.chromium.org/625443002/) Reason for revert: Suspecting this for failing test: https://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/53374/steps/content_browsertests/logs/ResetBrowserAccessibilityManager Original issue's description: > Reset accessibility if it gets out of sync. > > Previously if the browser got an accessibility IPC it was unable to > interpret, it killed the renderer. This change makes it reset the > accessibility state instead so we're tolerant of corner cases that > are very difficult to completely eliminate in practice. > > The accessibility reset is designed to be safe, it throws away all > accessibility state on the browser side and waits for an IPC from > the renderer acknowledging the renderer reset as well. > > BUG=372478 > > Committed: https://crrev.com/0c5e8d16661df7e08c708997f24c0a3070e58080 > Cr-Commit-Position: refs/heads/master@{#298297} TBR=nasko@chromium.org,tsepez@chromium.org,mkwst@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=372478 Committed: https://crrev.com/883b07f3e5555a5efad7771e968e950725e3d748 Cr-Commit-Position: refs/heads/master@{#298315}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -288 lines) Patch
D content/browser/accessibility/accessibility_ipc_error_browsertest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 4 chunks +1 line, -23 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 7 chunks +4 lines, -40 lines 0 comments Download
M content/common/accessibility_messages.h View 1 chunk +3 lines, -19 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.cc View 4 chunks +1 line, -14 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_focus_only.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jackhou1
Created Revert of Reset accessibility if it gets out of sync.
6 years, 2 months ago (2014-10-07 00:23:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629413002/1
6 years, 2 months ago (2014-10-07 00:27:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as cf2aba9397a2cfbf2dd1651b2ccb60fd1b3de65c
6 years, 2 months ago (2014-10-07 00:33:05 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 00:33:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/883b07f3e5555a5efad7771e968e950725e3d748
Cr-Commit-Position: refs/heads/master@{#298315}

Powered by Google App Engine
This is Rietveld 408576698