Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 629333002: Add OWNERS suppressions for the test_expectations* files. (Closed)

Created:
6 years, 2 months ago by Dirk Pranke
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add OWNERS suppressions for the test_expectations* files. We had a blanket approval for these files when they lived in webkit/tools/layout_tests, but that approval didn't get moved over to content/tests when we moved the files themselves. R=sky@chromium.org BUG=338338 Committed: https://crrev.com/1c748de9cbdfc60851005a9402da3c67de70b079 Cr-Commit-Position: refs/heads/master@{#298330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/test/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dirk Pranke
6 years, 2 months ago (2014-10-06 21:11:55 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-10-06 21:14:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629333002/1
6 years, 2 months ago (2014-10-06 21:26:19 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 00:45:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629333002/1
6 years, 2 months ago (2014-10-07 00:47:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9c0ab0c7591645ee1636deb555998eb003614326
6 years, 2 months ago (2014-10-07 02:24:37 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 02:25:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c748de9cbdfc60851005a9402da3c67de70b079
Cr-Commit-Position: refs/heads/master@{#298330}

Powered by Google App Engine
This is Rietveld 408576698