Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 629243003: Forward compositor and input tasks to the Blink scheduler (Closed)

Created:
6 years, 2 months ago by Sami
Modified:
6 years, 2 months ago
CC:
alex clarke (OOO till 29th), chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, petrcermak, picksi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Forward compositor and input tasks to the Blink scheduler The re-entrancy issues with the Blink scheduler have been resolved, so we can forward compositor and input tasks to it again -- if the scheduler is enabled. Depends on https://codereview.chromium.org/621363002. BUG=391005 TEST=No instances of "Scheduler::executeHighPriorityTasks" found in trace when running chrome with --disable-blink-scheduler. Committed: https://crrev.com/c30aa408450d0fd3713ec6d7775b9c801731ed7e Cr-Commit-Position: refs/heads/master@{#299105}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/renderer/render_thread_impl.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Sami
The Blink scheduler is now running in pass-through mode while we figure out the best ...
6 years, 2 months ago (2014-10-06 17:23:21 UTC) #3
Sami
Ping?
6 years, 2 months ago (2014-10-08 11:11:27 UTC) #5
picksi1
https://codereview.chromium.org/629243003/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/629243003/diff/1/content/renderer/render_thread_impl.cc#newcode858 content/renderer/render_thread_impl.cc:858: Stylistic Nit: I'd favor swapping the if/else and removing ...
6 years, 2 months ago (2014-10-08 12:44:38 UTC) #7
Sami
https://codereview.chromium.org/629243003/diff/1/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/629243003/diff/1/content/renderer/render_thread_impl.cc#newcode858 content/renderer/render_thread_impl.cc:858: On 2014/10/08 12:44:37, picksi1 wrote: > Stylistic Nit: I'd ...
6 years, 2 months ago (2014-10-08 12:54:32 UTC) #8
Sami
jochen@, could you have a look?
6 years, 2 months ago (2014-10-09 16:26:03 UTC) #10
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-10 11:10:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629243003/20001
6 years, 2 months ago (2014-10-10 12:44:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-10 13:49:17 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 13:49:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c30aa408450d0fd3713ec6d7775b9c801731ed7e
Cr-Commit-Position: refs/heads/master@{#299105}

Powered by Google App Engine
This is Rietveld 408576698