Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 629203002: Replace OVERRIDE and FINAL with override and final in content/public/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-ipc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/public/[a-s]* BUG=417463 Committed: https://crrev.com/ded18c56a1f8cbe8bc8f3e25ed934ea295961569 Cr-Commit-Position: refs/heads/master@{#298459}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -232 lines) Patch
M content/public/browser/browser_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_message_filter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/browser/desktop_media_id.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/platform_event_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_frame_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/browser_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/browser_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 4 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/content_browser_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/test/content_browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/content_test_suite_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/download_test_observer.h View 6 chunks +12 lines, -12 lines 0 comments Download
M content/public/test/fake_speech_recognition_manager.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/public/test/frame_load_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/javascript_test_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_download_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/mock_download_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 2 chunks +45 lines, -45 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 chunk +30 lines, -30 lines 0 comments Download
M content/public/test/mock_resource_context.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/mock_special_storage_policy.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/public/test/mock_storage_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/public/test/nested_message_pump_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/test/render_view_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +13 lines, -13 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/test_browser_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/test_file_error_injector.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/test/test_file_system_backend.h View 1 chunk +15 lines, -15 lines 0 comments Download
M content/public/test/test_file_system_backend.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M content/public/test/test_launcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/test/test_navigation_observer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/test/test_notification_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_renderer_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/test/test_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
jochen@chromium.org: Please review changes in content/public module
6 years, 2 months ago (2014-10-06 13:13:28 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-07 09:56:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629203002/20001
6 years, 2 months ago (2014-10-07 10:59:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 89d05070de6c674320e8d5abf09e6b025e593e68
6 years, 2 months ago (2014-10-07 13:07:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:08:27 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ded18c56a1f8cbe8bc8f3e25ed934ea295961569
Cr-Commit-Position: refs/heads/master@{#298459}

Powered by Google App Engine
This is Rietveld 408576698