Extended: Add "system" URLRequestContext

chrome/browser/system_url_request_context_getter.h

Index: chrome/browser/system_url_request_context_getter.h
diff --git a/chrome/browser/system_url_request_context_getter.h b/chrome/browser/system_url_request_context_getter.h
new file mode 100644
index 0000000000000000000000000000000000000000..0de81e7db4b8f6e1274cf8143063f5b4d74f8902
--- /dev/null
+++ b/chrome/browser/system_url_request_context_getter.h
@@ -0,0 +1,27 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYSTEM_URL_REQUEST_CONTEXT_GETTER_H_
+#define CHROME_BROWSER_SYSTEM_URL_REQUEST_CONTEXT_GETTER_H_
+#pragma once
+
+#include "chrome/common/net/url_request_context_getter.h"
+
+class IOThread;
+
+class SystemURLRequestContextGetter : public URLRequestContextGetter {
+ public:
+  explicit SystemURLRequestContextGetter(IOThread* io_thread);

[willchan no longer on Chromium, 2011/02/08 22:52:04]

We try to make sure there's only 1 URLRequestContextGetter per
URLRequestContext. This subtype does not appear to be able to enforce that,
since anyone can publicly create it.

I suggest having IOThread have a member variable:
mutable scoped_refptr<URLRequestContextGetter>
system_url_request_context_getter_;

Provide an accessor: scoped_refptr<URLRequestContextGetter>
IOThread::system_url_request_context_getter() const;

Have this one lazily instantiate it, with the definition in the .cc file.

In io_thread.cc, put the SystemURLRequestContextGetter class definition in the
anonymous namespace. Implement it there.

This way, SystemURLRequestContextGetter is completely hidden from users, the
only thing exposed is a way to get a system_url_request_context_getter from the
IOThread class.

[battre, 2011/02/14 18:22:05]

Done.

+  virtual ~SystemURLRequestContextGetter();
+
+  // Implementation for UrlRequestContextGetter.
+  virtual net::URLRequestContext* GetURLRequestContext();
+  virtual scoped_refptr<base::MessageLoopProxy> GetIOMessageLoopProxy() const;
+
+ private:
+  IOThread* io_thread_;  // Weak pointer, owned by BrowserProcess.

[willchan no longer on Chromium, 2011/02/08 22:52:04]

IOThread* const io_thread_;

[battre, 2011/02/14 18:22:05]

Done.

+  scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
+};

[willchan no longer on Chromium, 2011/02/08 22:52:04]

Please add a LeakTracker for this class and assert in IOThread::CleanUp() that
it is deleted. We should make sure people aren't holding onto references to
SystemURLRequestContextGetter for too long.

[battre, 2011/02/14 18:22:05]

Done.

+
+#endif  // CHROME_BROWSER_SYSTEM_URL_REQUEST_CONTEXT_GETTER_H_