[Easy Unlock] Port RemoteStatusUpdate class to native code.

[Easy Unlock] Port RemoteStatusUpdate class to native code.

BUG=421277
TEST=components_unittests
R=tengs@chromium.org

Committed: https://crrev.com/e6f0e2b174775dc33babafc2aafa64629017a565
Cr-Commit-Position: refs/heads/master@{#299075}

[Tim Song, 2014-10-09 19:07:30]

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
File components/proximity_auth/remote_status_update.cc (right):

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
components/proximity_auth/remote_status_update.cc:64: VLOG(1) << "Unable to
parse remote status update: missing data value.";
Also log the json string.

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
File components/proximity_auth/remote_status_update_unittest.cc (right):

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
components/proximity_auth/remote_status_update_unittest.cc:9: namespace
proximity_auth {
Can you add one more test for when the JSON is valid but also contains
additional unexpected fields? We may want to add some extra fields in the
future, and the parsing should still work.

[Ilya Sherman, 2014-10-09 22:52:33]

In addition to addressing your comments, I've refactored the deserialization
method to accept a base::DictionaryValue rather than an std::string.  I realized
that this makes more sense as I was working on the Client code, which will be
calling this function.

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
File components/proximity_auth/remote_status_update.cc (right):

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
components/proximity_auth/remote_status_update.cc:64: VLOG(1) << "Unable to
parse remote status update: missing data value.";
On 2014/10/09 19:07:30, Tim Song wrote:
> Also log the json string.

Done.

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
File components/proximity_auth/remote_status_update_unittest.cc (right):

https://codereview.chromium.org/629183003/diff/1/components/proximity_auth/re...
components/proximity_auth/remote_status_update_unittest.cc:9: namespace
proximity_auth {
On 2014/10/09 19:07:30, Tim Song wrote:
> Can you add one more test for when the JSON is valid but also contains
> additional unexpected fields? We may want to add some extra fields in the
> future, and the parsing should still work.

Done.

[Tim Song, 2014-10-10 06:52:11]

lgtm

Great!

[Ilya Sherman, 2014-10-10 07:15:44]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-10-10 07:17:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629183003/50001

[commit-bot: I haz the power, 2014-10-10 08:11:46]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2014-10-10 08:12:54]

Patchset 3 (id:??) landed as
https://crrev.com/e6f0e2b174775dc33babafc2aafa64629017a565
Cr-Commit-Position: refs/heads/master@{#299075}