Remove RenderObject::isMarquee()

Source/core/rendering/RenderBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 2020 matching lines @@
         return true;
 
     // We don't stretch multiline flexboxes because they need to apply line spacing (align-content) first.
     if (parent->isFlexibleBox() && parent->style()->flexWrap() == FlexNoWrap && parent->style()->isColumnFlexDirection() && columnFlexItemHasStretchAlignment(flexitem))
         return true;
     return false;
 }
 
 bool RenderBox::sizesLogicalWidthToFitContent(const Length& logicalWidth) const
 {
     // Marquees in WinIE are like a mixture of blocks and inline-blocks.  They size as though they're blocks,

[mstensho (USE GERRIT), 2014/10/06 20:00:34]

This comment about marquees is no longer valid.

[Hajime Morrita, 2014/10/06 20:22:10]

Done.

     // but they allow text to sit on the same line as the marquee.
-    if (isFloating() || (isInlineBlockOrInlineTable() && !isMarquee()))
+    if (isFloating() || (isInlineBlockOrInlineTable()))

[mstensho (USE GERRIT), 2014/10/06 20:00:34]

Extraneous set of parentheses.

[Hajime Morrita, 2014/10/06 20:22:10]

Done.

         return true;
 
     if (logicalWidth.type() == Intrinsic)
         return true;
 
-    // Children of a horizontal marquee do not fill the container by default.
-    // FIXME: Need to deal with MAUTO value properly.  It could be vertical.
-    // FIXME: Think about block-flow here.  Need to find out how marquee direction relates to
-    // block-flow (as well as how marquee overflow should relate to block flow).
-    // https://bugs.webkit.org/show_bug.cgi?id=46472
-    if (parent()->isMarquee()) {
-        EMarqueeDirection dir = parent()->style()->marqueeDirection();
-        if (dir == MAUTO || dir == MFORWARD || dir == MBACKWARD || dir == MLEFT || dir == MRIGHT)
-            return true;
-    }
-
     // Flexible box items should shrink wrap, so we lay them out at their intrinsic widths.
     // In the case of columns that have a stretch alignment, we go ahead and layout at the
     // stretched size to avoid an extra layout when applying alignment.
     if (parent()->isFlexibleBox()) {
         // For multiline columns, we need to apply align-content first, so we can't stretch now.
         if (!parent()->style()->isColumnFlexDirection() || parent()->style()->flexWrap() != FlexNoWrap)
             return true;
         if (!columnFlexItemHasStretchAlignment(this))
             return true;
     }
@@ skipping 1720 matching lines @@
         }
     }
 
     if (closestRenderer)
         return closestRenderer->positionForPoint(adjustedPoint - closestRenderer->locationOffset());
     return createPositionWithAffinity(firstPositionInOrBeforeNode(nonPseudoNode()));
 }
 
 bool RenderBox::shrinkToAvoidFloats() const
 {
     // Floating objects don't shrink.  Objects that don't avoid floats don't shrink.  Marquees don't shrink.

[mstensho (USE GERRIT), 2014/10/06 20:00:34]

Can you remove the comment about marquees, please?

[Hajime Morrita, 2014/10/06 20:22:10]

Done.

-    if ((isInline() && !isMarquee()) || !avoidsFloats() || isFloating())
+    if (isInline() || !avoidsFloats() || isFloating())
         return false;
 
     // Only auto width objects can possibly shrink to avoid floats.
     return style()->width().isAuto();
 }
 
 static bool isReplacedElement(Node* node)
 {
     // Checkboxes and radioboxes are not isReplaced() nor do they have their own renderer in which to override avoidFloats().
     return node && node->isElementNode() && toElement(node)->isFormControlElement();
@@ skipping 697 matching lines @@
     ASSERT(style()->hasBackground() || style()->hasBoxDecorations());
 
     if (m_rareData && m_rareData->m_previousBorderBoxSize.width() != -1)
         return m_rareData->m_previousBorderBoxSize;
 
     // We didn't save the old border box size because it was the same as the size of oldBounds.
     return previousBoundsSize;
 }
 
 } // namespace blink