Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 629103002: Don't use mock PagePopup if possible. (Closed)

Created:
6 years, 2 months ago by tkent
Modified:
6 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Don't use mock PagePopup if possible. Update some tests in fast/forms/{calendar-picker,color,page-popup}/ so that they use openPicker() instead of openPickerWithMock(). BUG=409503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -56 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-required.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-ru.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-step.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-date-types.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-date-types-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-datetimelocal.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-datetimelocal-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-datetimelocal-with-step.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-datetimelocal-with-step-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-key-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-pre-100-year.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-pre-100-year-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-with-step.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-ax-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-choose-default-value-after-set-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-events.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-events-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-choose-default-value-after-set-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-events.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-events-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-appearance-step.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-ax-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-choose-default-value-after-set-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-key-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-with-step.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-with-step-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-appearance-step.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-ax-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-choose-default-value-after-set-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-key-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-one-row-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-two-row-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/page-popup/page-popup-adjust-rect.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/page-popup/page-popup-adjust-rect-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-expected.png View Binary file 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, please review this.
6 years, 2 months ago (2014-10-06 02:54:09 UTC) #2
keishi
lgtm
6 years, 2 months ago (2014-10-06 02:59:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629103002/1
6 years, 2 months ago (2014-10-06 05:00:54 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 08:03:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183249

Powered by Google App Engine
This is Rietveld 408576698