Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Issue 629083002: Move run_webkit_tests.* script into their new home. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
Dirk Pranke, eseidel
CC:
chromium-reviews, darin (slow to review), abarth-chromium, eseidel, jochen (gone - plz use gerrit), jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move run_webkit_tests.* script into their new home. As we are removing webkit/ glue, we need a new home for these scripts. BUG=338338 TEST=None R=dpranke@chromium.org Committed: https://crrev.com/a16e8bc1de2136c13428818295663cd46681e5e8 Cr-Commit-Position: refs/heads/master@{#299051}

Patch Set 1 : #

Patch Set 2 : fix checkperms #

Patch Set 3 : add OWNERS back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -42 lines) Patch
A + blink/tools/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A blink/tools/run_layout_tests.bat View 1 1 chunk +1 line, -0 lines 0 comments Download
A + blink/tools/run_layout_tests.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + blink/tools/run_layout_tests.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download
D webkit/tools/layout_tests/run_webkit_tests.bat View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/tools/layout_tests/run_webkit_tests.py View 1 chunk +0 lines, -21 lines 0 comments Download
D webkit/tools/layout_tests/run_webkit_tests.sh View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 28 (9 generated)
tfarina
Is this OK? Is this final location ok?
6 years, 2 months ago (2014-10-06 00:27:51 UTC) #4
dcheng
On 2014/10/06 00:25:53, tfarina wrote: > Patchset #1 (id:1) has been deleted Maybe before outright ...
6 years, 2 months ago (2014-10-06 00:28:36 UTC) #5
Dirk Pranke
I defer this to Eric to sign off on, to make sure it won't mess ...
6 years, 2 months ago (2014-10-06 00:32:59 UTC) #7
tfarina
On 2014/10/06 00:28:36, dcheng wrote: > On 2014/10/06 00:25:53, tfarina wrote: > > Patchset #1 ...
6 years, 2 months ago (2014-10-06 00:33:32 UTC) #8
jamesr
I suspect having files in the blink/ subdirectory will make merging the repo in to ...
6 years, 2 months ago (2014-10-06 01:00:27 UTC) #9
eseidel
It might. We can also just move them out of the way before we dcommit ...
6 years, 2 months ago (2014-10-06 16:53:23 UTC) #10
eseidel
lgtm I doubt this matters either way.
6 years, 2 months ago (2014-10-06 19:14:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629083002/60001
6 years, 2 months ago (2014-10-06 19:17:11 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/15747)
6 years, 2 months ago (2014-10-06 19:34:20 UTC) #15
tfarina
Thanks Eric. Dirk, could you approve for webkit/tools/layout_tests/?
6 years, 2 months ago (2014-10-06 20:55:01 UTC) #16
Dirk Pranke
On 2014/10/06 20:55:01, tfarina wrote: > Thanks Eric. > > Dirk, could you approve for ...
6 years, 2 months ago (2014-10-06 21:05:34 UTC) #17
Dirk Pranke
On 2014/10/06 21:05:34, Dirk Pranke wrote: > On 2014/10/06 20:55:01, tfarina wrote: > > Thanks ...
6 years, 2 months ago (2014-10-06 21:08:17 UTC) #18
Dirk Pranke
On 2014/10/06 21:08:17, Dirk Pranke wrote: > Oh, but looking at this made me realize that ...
6 years, 2 months ago (2014-10-06 21:12:31 UTC) #19
dcheng
On 2014/10/06 at 00:33:32, tfarina wrote: > On 2014/10/06 00:28:36, dcheng wrote: > > On ...
6 years, 2 months ago (2014-10-08 01:42:38 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629083002/60001
6 years, 2 months ago (2014-10-10 02:09:01 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered_tests/builds/55105) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16832)
6 years, 2 months ago (2014-10-10 02:18:44 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629083002/280001
6 years, 2 months ago (2014-10-10 02:34:55 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:280001)
6 years, 2 months ago (2014-10-10 03:11:40 UTC) #27
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 03:12:22 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a16e8bc1de2136c13428818295663cd46681e5e8
Cr-Commit-Position: refs/heads/master@{#299051}

Powered by Google App Engine
This is Rietveld 408576698