Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 629008: Make sure that post-interceptor property getter doesn't assume name lookup is... (Closed)

Created:
10 years, 10 months ago by dglazkov
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make sure that post-interceptor property getter doesn't assume name lookup is enough. R=ager TEST=none BUG=20104

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/objects.cc View 1 chunk +7 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
dglazkov
10 years, 10 months ago (2010-02-18 00:29:36 UTC) #1
antonm
Dmitry, may you add v8 reduction for this fix?
10 years, 10 months ago (2010-02-18 07:53:41 UTC) #2
Mads Ager (chromium)
Dimitri, can I steal this bug? The result.IsValid() check should have been enough to ensure ...
10 years, 10 months ago (2010-02-18 08:29:30 UTC) #3
Mads Ager (chromium)
10 years, 10 months ago (2010-02-18 13:13:14 UTC) #4
The real problem here is that we test for IsValid instead of testing for
IsProperty.  I have cleaned up the use of the LookupResult class and added a
regression test for the issue in this change: 

http://codereview.chromium.org/647015

Powered by Google App Engine
This is Rietveld 408576698