Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 628983003: New error strings for chrome.bluetoothLowEnergy (Closed)

Created:
6 years, 2 months ago by Marie Janssen
Modified:
6 years, 2 months ago
Reviewers:
armansito
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

New error strings for chrome.bluetoothLowEnergy Also use a new method for callback chaining, which is slightly less flexible but much less "callback hell". BUG=377232 R=armansito@chromium.org Committed: https://crrev.com/c3888beea787e75c7954590002603f5189b117ce Cr-Commit-Position: refs/heads/master@{#299390}

Patch Set 1 #

Patch Set 2 : add readDescriptorValue errors/tests #

Total comments: 2

Patch Set 3 : Shortened super-long constant names. #

Messages

Total messages: 9 (1 generated)
Marie Janssen
Method and new strings from the ConnectError. I plan to do the same for the ...
6 years, 2 months ago (2014-10-06 22:11:15 UTC) #1
Marie Janssen
Added in the error strings for Read/Write Characteristic/Descriptor Value to this one since they are ...
6 years, 2 months ago (2014-10-07 19:48:05 UTC) #2
armansito
https://codereview.chromium.org/628983003/diff/20001/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc File extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc (right): https://codereview.chromium.org/628983003/diff/20001/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc#newcode990 extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc:990: BluetoothGattService::GattErrorCode::GATT_ERROR_INVALID_LENGTH)) nit: I would ditch the "GattErrorCode::" in between.
6 years, 2 months ago (2014-10-13 18:51:37 UTC) #3
Marie Janssen
Shortened the names. PTAL. https://codereview.chromium.org/628983003/diff/20001/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc File extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc (right): https://codereview.chromium.org/628983003/diff/20001/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc#newcode990 extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc:990: BluetoothGattService::GattErrorCode::GATT_ERROR_INVALID_LENGTH)) On 2014/10/13 18:51:37, armansito ...
6 years, 2 months ago (2014-10-13 21:22:49 UTC) #4
armansito
lgtm
6 years, 2 months ago (2014-10-13 21:26:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628983003/50001
6 years, 2 months ago (2014-10-13 21:44:58 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:50001)
6 years, 2 months ago (2014-10-13 23:28:02 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 23:28:59 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c3888beea787e75c7954590002603f5189b117ce
Cr-Commit-Position: refs/heads/master@{#299390}

Powered by Google App Engine
This is Rietveld 408576698